Single Page, Nav Highlighting Stopped Working with B5 5

15 replies · opened Jun 5, 2021

CcarabsJun 5, 2021

Hello,

I pulled your latest version (6.4) and found the on a single page, the navigation is no longer highlighted as I scroll. For example:

http://themes.semicolonweb.com/html/canvas/op-side-header.html

In the previous version, the links in the left nav were highlighted with the proper section as you scroll down. But this no longer happens.

Anything I can do? I am not a fan of single-page designs that do not highlight the section link.

Thanks.

SSemicolon WebSTAFFJun 6, 2021

Hello,

Thanks for your Patience!

Apologies for the Inconveniences regarding this issue! We confirm this bug and we are looking into this. We will provide you with the fix within a few hours. Thanks for your Patience.

Meanwhile, do let us know if we can help you with anything else or if you find any further issues with Canvas.

CcarabsJun 8, 2021

Thank you for the response.

Though I am sure your fix will address all the issues associated to this, I found a second issue with the nav highlighting. Once the user clicks a nav link, that link is highlighted in the nav. But as I scroll that highlight never goes away. A specific example:

SSemicolon WebSTAFFJun 8, 2021

Thanks so much for your Kind Patience!

Yes we have detected the another issue while testing. Meanwhile, we have already fixed this issue. Consider using the updated js/plugins.min.js File attached to this reply. This will fix this issue across all the One Page functionalities (Side Headers or Page Sub-Menus).

Hope this Helps!

Let us know if we can help you with anything else or if you find any further issues.

CcarabsJun 9, 2021

Thank you for the fix. I confirmed it is now working as expected. But the movement is not natural IMHO. That initial delay is too long, and the overall movement is just slow. I took a video of my local development... https://youtu.be/Z87w-tIUDKQ

Is there a way to control the speed?

CcarabsJun 9, 2021

I added your plugins.min.js file to my locally checked out version of your entire theme and it is scrolling at a better speed... https://youtu.be/Z7OGQyHc3jE

Maybe the issue I noted in my previous comment is happening because of how I include the JS files? I use Gulp to minify and combine files. Can you clarify something for me...

Within op-side-header.html, you include the following, in the following order:

  • js/jquery.js
  • js/plugins.min.js
  • js/functions.js

Within my Gulp process, I minify js/functions.js and combine js/jquery.js, js/plugins.min.js and the minified functions.js into a new file that I use in my design.

Do you see issues with minifying js/functions.js?

If this goes beyond the support you can give I will understand. But I had not seen this speed issue before I upgraded.

Looking forward to your response.

Update - I have made sure my gulp process matches the order of the files you include, and I do not perform any minification/modification on your files at all. I see the same slow speed. This means the only real difference between my 1 file JS strategy vs including all 3 files (like you do) should not really matter. Right? I still feel this is an issue with the new version. So I reverted to the previous version of Canvas (pre-BS5) and the scrolling worked without the same weird delay... https://youtu.be/MAbjKL5ewkM I think it is just an issue with the new Canvas version... but I can not figure out why. Any thoughts?

Update 2 - I have removed my single JS file, and instead include all three of the primary JS files directly from the ZIP I downloaded from Theme Forest. I still have the scrolling issue. Did anything change on the structure of the op-side-header.html that I need to now include? Kinda makes me nervous upgrading my other live websites to the latest canvas.

SSemicolon WebSTAFFJun 9, 2021

Your JS Codes minification will not cause any issue as this issue is due to changes in CSS Codes in Bootstrap 5. Make sure the Order of the CSS is according to the Default Files and the style.css file is at the Latest Version. Bootstrap 5 enables smooth scrolling by default which we have already disabled in the Latest style.css File. Here is the Code to disable it:
[ch_pre type="css"]@media (prefers-reduced-motion: no-preference) {
:root {
scroll-behavior: auto;
}
}[/ch_pre]

Our Live Previews does not have this issue: http://themes.semicolonweb.com/html/canvas/op-index.html .

This will definitely fix the issue. Hope this Helps!

Let us know if we can help you with anything else or if you find any further issues.

CcarabsJun 9, 2021

Thank you for the reply. I do not have my gulp project code in front of me, but I believe I include style.scss when building my CSS. I assume the order would be correct in there. I will confirm later tonight.

Thanks again.

SSemicolon WebSTAFFJun 9, 2021

Thanks for pointing this out to us! There might be a minor bug in our SCSS Files. Allow us a few hours as we are going through the codes. We will provide you with the complete codes related to this shortly. Please be assured that we will fix all these issues for you as these are very minor bugs due to the Major Bootstrap Upgrade. We really really apologize about continuously going back and forth on this. This absolutely should not happen!

Thanks for your Super Kind Patience.

CcarabsJun 9, 2021

It's all good. The BS 4->5 conversion is a pretty big change. If someone had just grabbed the latest version JS/CSS and uploaded it they would have been in trouble. I was surprised that there wasn't more specific information documented about the upgrade within your docs/communication. It will all work itself out soon.

SSemicolon WebSTAFFJun 10, 2021

We absolutely understand. We will make it a point to Highlight the changes more efficiently so that it is more evident. Meanwhile, we have already updated the SCSS Files and we have attached them to this reply. Simply update these files with the existing ones and your issues should be resolved. The _misc.scss File is inside sass/shortcodes/ Folder

Hope this Helps!

Let us know if we can help you with anything else or if you find any further issues.

CcarabsJun 10, 2021

Thank you for the reply. I ran a quick test and still see that same delay as before. I checked the files and the _content.scss and _misc.scss files you shared are the same exact files I already have. And _layouts.scss only has an extra line, but no code changes. Did you upload the right changes? Though I am Ok with waiting for your next release, I would also like to test and help you out (if I can).

SSemicolon WebSTAFFJun 10, 2021

Apologies! There was an Update delay with Google Drive. Try the Latest Files attached to these reply.

These should work fine.

CcarabsJun 11, 2021

I brought these files into my project and ran my Gulp script to build the CSS. I no longer see the delay as I previously had.

Do you know when this will be available in an actual Canvas version/release?

Thank you again for addressing this.

SSemicolon WebSTAFFJun 11, 2021

Very Happy to Help and Glad that the issue was resolved! :)

A Silent Update has already been released and available on ThemeForest as this should already have been included in the previous versions.

Do let us know if we can help you with anything else or if you find any further issues with Canvas.

Have the same question, or something new?

Sign in to the Canvas dashboard to reply or open your own topic. Canvas owners get direct help from the SemiColonWeb team.

Reply on the dashboard