BUG: common-height

hi

I found a little bug that prevents common-height class to work correctly.

		commonHeight: function( element ){
			var maxHeight = 0;
			element.children('[class*=col-]').each(function() {
				// var element = $(this).children(); //---- ORIGINAL
				var element = $(this) //------------------- FIXED
				if( element.hasClass('max-height') ){
					maxHeight = element.outerHeight();
				} else {
					if (element.outerHeight() > maxHeight)
					maxHeight = element.outerHeight();
				}
			});

the ORIGINAL and FIXED comments shows the bug-fix difference.

at the Original line, $(this) points to children of a container with common-height class. those should be watched for height.(technically max-height). and you are querying $(this) children and looking for hasClass... in the next line on the QUERY object.

I think with removing .children() code works as it is expected.

thank you

yes I was wrong. please delete this thread if you like. thank you